The EventCalendar 3.0.1 plugin for WordPress was failing XHTML validation because of incorrect nesting of tags, so I took a look and fixed it. Here’s the patch:
--- eventcalendar3_1.php 2005-08-16 17:01:42.003399602 -0400
+++ eventcalendar3.php 2005-08-16 16:58:27.088002867 -0400
@@ -616,10 +616,11 @@
$pad=7-$col;
if($pad>1)
echo "<td colspan='$pad' class='pad' style='vertical-align:bottom'>"
- . "<a href='http://blog.firetree.net/?ec3_version=$ec3->version'"
- . " title='Event Calendar $ec3->version'"
+ . "<div class='ec3_ec'"
. ($ec3->hide_logo? " style='display:none'>": ">")
- . "<div class='ec3_ec'> </div></a></td>";
+ . "><a href='http://blog.firetree.net/?ec3_version=$ec3->version'"
+ . " title='Event Calendar $ec3->version'>"
+ . " </a></div></td>";
elseif($pad)
echo "<td colspan='$pad' class='pad'> </td>";
You can test the XHTML on my page to see it in action.
Tags: development, geekiness
[...] In related news, my patch to fix XHTML compliance in the great EventCalendar plugin was incorporated into the latest release today (well, it’s 12:30am, so really it was yesterday, but who’s counting?). Sent in a couple crash traces to Amarok today as well, since I use bleeding edge SVN code and after updating and recompiling today it started crashing out on me on playback. As of this evening it works again, so hopefully my reports helped make that possible. I also reported a couple more phpdoc errors in the Gallery code (one of which I went on to accidentally copy and paste into my code, which my mentor then pointed out, heh.. stupid me) and wrote a patch for their phpunit testing platform that was briefly committed and then rolled back because philosophical concerns regarding Gallery’s testing methodology. It all started from a minor problem I was having with some unit tests I had written. I asked about it and wound up providing a very little patch to fix this problem, and from there it exploded into a big discussion, a revert of the patch, and now I have to write an entire additional abstraction layer for my module! It was quite unexpected, to say the least. It is for the best, though, as I learned something new and my code will be much better for it. It also lead to me having a great talk with my mentor, Andy a.k.a. “valiant,” in which he helped me out with this new bit that I have to tackle and also offered his very kind and sincere hope that, despite the frustrations of working with Zen Cart, I had enjoyed and benifited from doing this project. Which I can honestly say I have. :) [...]